Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add nilness check in govet #86

Merged
merged 2 commits into from
Jul 23, 2024
Merged

ci: add nilness check in govet #86

merged 2 commits into from
Jul 23, 2024

Conversation

taoky
Copy link
Member

@taoky taoky commented Jul 23, 2024

To prevent this kind of incorrect pattern:

if err != nil {
    return err
}

res := xxxxx()
if err != nil {
    // ...
}

@taoky taoky enabled auto-merge (squash) July 23, 2024 20:34
@taoky taoky merged commit 63bdc74 into main Jul 23, 2024
3 checks passed
@taoky taoky deleted the nilness-1 branch July 23, 2024 20:35
Copy link
Member

@knight42 knight42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 赞!这个 check 也帮我发现了别的项目的问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants