USWDS-Site: Add changelogs for autocomplete email attribute [#6002] #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
todo: This feels like a good one to make a note of in the release notes so users know they can improve their implementation by adding this attribute. |
mahoneycm
approved these changes
Sep 3, 2024
amyleadem
commented
Sep 6, 2024
Comment on lines
-7
to
+9
| test_status: exception | ||
| test_status: pass | ||
| test_type: general | ||
| status_details: The input is appropriately marked as an "email" input type, but does not have the autocomplete attribute in the default component example. Be sure to add the `autocomplete="email"` attribute to the email input element in your implementation of the component. | ||
| github_issue_number: 6001 | ||
| github_issue_repo: uswds | ||
| version_tested: 3.8.1 | ||
| version_tested: N.N.N |
There was a problem hiding this comment.
Note
PR uswds/uswds#6002 resolves an accessibility issue that was previously marked as "passed with exceptions.
There was a problem hiding this comment.
LGTM, test_status: pass
amyleadem
commented
Sep 6, 2024
| github_issue_number: 6001 | ||
| github_issue_repo: uswds | ||
| version_tested: 3.8.1 | ||
| version_tested: N.N.N |
There was a problem hiding this comment.
Note
We should update this value to match its related release.
Suggested change
| version_tested: N.N.N | |
| version_tested: 3.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
We need to update the changelog dates before merge.
Related issue
Related to uswds/uswds#6001
Preview link
Testing and review