Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Site: Add changelog for Enable mixin in card component [#5974] #2805

Merged
merged 11 commits into from
Oct 3, 2024
Merged

USWDS-Site: Add changelog for Enable mixin in card component [#5974] #2805

merged 11 commits into from
Oct 3, 2024

Conversation

cathybaptista
Copy link
Contributor

@cathybaptista cathybaptista commented Sep 3, 2024 •
edited
Loading

Summary

Changelog for uswds/uswds#5974

Related PR

uswds/uswds#5974

Preview link

Preview link:
Card changelog

@cathybaptista cathybaptista changed the title USWDS-Site: Add changelog for Enable typeset mixin value in card component [#5974]#XXXX USWDS-Site: Add changelog for Enable typeset mixin value in card component [#5974] Sep 3, 2024
@cathybaptista cathybaptista mentioned this pull request Sep 3, 2024
Merged
7 tasks
@cathybaptista cathybaptista changed the title USWDS-Site: Add changelog for Enable typeset mixin value in card component [#5974] USWDS-Site: Add changelog for Enable mixin in card component [#5974] Sep 3, 2024
@cathybaptista cathybaptista marked this pull request as ready for review September 3, 2024 21:57
mahoneycm
mahoneycm requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: I like that you linked the preview link directly to the changelog section! Thanks for that 😄

todo: Small wording suggestion to add a bit of clarity to the changelog. Thanks @cathybaptista !

_data/changelogs/component-card.yml Outdated Show resolved Hide resolved
@mahoneycm mahoneycm changed the base branch from main to release-3.9.0 September 5, 2024 14:10
mahoneycm
mahoneycm approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Updated the target branch to the release-3.9.0 👍

@mahoneycm mahoneycm mentioned this pull request Sep 18, 2024
Merged
3 tasks
@amyleadem amyleadem requested review from thisisdano and removed request for RachelCorsino September 30, 2024 23:20
mejiaj
mejiaj approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Information looks correct.

@amyleadem amyleadem merged commit 2d8a848 into release-3.9.0 Oct 3, 2024
6 of 8 checks passed
@amyleadem amyleadem deleted the cb-changelog-5974 branch October 3, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahoneycm mahoneycm mahoneycm approved these changes

@amyleadem amyleadem amyleadem approved these changes

@mejiaj mejiaj mejiaj approved these changes

@thisisdano thisisdano Awaiting requested review from thisisdano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cathybaptista @mejiaj @mahoneycm @amyleadem