Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - Feature: Add ECAP to Showcase #2839

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brunerae
Copy link
Contributor

@brunerae brunerae commented Sep 20, 2024

Summary

Add ECAP to showcase.

Important

We need to update the changelog date before merge

Related issue

Closes #2704

Preview link

Showcase page

Testing and review

  1. Navigate to Showcase
  2. Confirm Export Compliance Assistance Program is listed
  3. Confirm the changelog is present and accurate

amyleadem
amyleadem previously approved these changes Oct 28, 2024
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - The site name and url match the issue, and the link works as expected.

@amyleadem
Copy link
Contributor

Actually, just realized this needs a changelog. I'll go ahead and add it (and might do some backfill on missed changelog entries for this page)

@amyleadem amyleadem dismissed their stale review October 28, 2024 15:09

Dismissing approval while I add a changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USWDS-Site - Feature: Add Export Compliance Assistance Program (ECAP) site to Showcase
2 participants