This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
upgrade to v1.20 libraries, fixes issue#484 #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,8 @@ COPY pkg/ pkg/ | |||
| COPY proto/ proto/ | |||
| COPY Makefile Makefile | |||
|
|
|||
| # As (generated) proto/service.pb.go is _also_ committed, void the need to install protoc / protoc-gen-go plugin | |||
| RUN touch proto/service.pb.go | |||
There was a problem hiding this comment.
can you explain this change a bit more? I don't quite follow, we already copy the whole proto directory into the build container as per line 14
There was a problem hiding this comment.
sure, but depending on the mtime timestamp from the copy, it may trigger rebuilding proto/service.pb.go which may endup producing a different file from the corresponding Makefile target (it shouldn't, but ...) -- ie I want to be 100% sure we're using the committed file, also not enter into the biz of go get ...ing the protoc compiler at docker build time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #484.
rather than doing it at build time -- as it's already committed,
it makes built artifacts deterministic/reproduceable from src tree
golang:1.15.15, same as upstream Kubernetes v1.20