Orcid Publications Import Optimization #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wunc I applied the changes we discussed yesterday and the PR is ready for review. I will work on the failing security check on a separate branch. |
betsyecastro
force-pushed
the
orcid-data-import-optimization
branch
from
a3389a0
to
761ccf4
Compare
Moved the Orcid import process from the Profile model to a new OrcidPublicationsRepository class. This class implements an interface and utilizes the new Publications helper to handle publication formatting methods to return author names in the APA citation format but scalable, to allow the addition of new formatting options.
Includes ProfileDataFactory for publications and authors, publications mock and feature test.
betsyecastro
force-pushed
the
orcid-data-import-optimization
branch
from
46131ed
to
628400d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds architecture changes for publications import
Includes the
PublicationsRepositoryContractinterface and theOrcidPublicationsRepositoryimplementation as a$publicationManagerdependency to handle various sources of publications.The
getPublication()method obtains multiple publications from the Orcid API in one request.Fetches additional publications information and uses the
Publicationhelper to format the publications in the APA citation style but it was designed to be scalable to allow different citation formats in the future.Feature test includes:
getPublications()method.