Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch v52 fix #470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sketch v52 fix #470

wants to merge 1 commit into from

Conversation

MacAndor
Copy link

@MacAndor MacAndor commented Oct 5, 2018

I don't really know whether this is a proper fix or not, but we were able to export a complex project with it.

@BMWx6
Copy link

BMWx6 commented Oct 5, 2018

Unfortunately this doesn't work for me. I am using Sketch 52.1
Here is the error:
Error: layerStyle.ObjectID is not a function. (In 'layerStyle.ObjectID()', 'layerStyle.ObjectID' is undefined)

@MacAndor
Copy link
Author

MacAndor commented Oct 5, 2018

I only tested it with Sketch v52.0. Waiting for https://github.com/abynim/Sketch-Headers to be updated

@BMWx6
Copy link

BMWx6 commented Oct 5, 2018

I did the changes manually only in 'Sketch Measure.sketchplugin/Contents/Sketch/library/common.js ' and it didn't work, but after replacing whole package the problem was solved and it works! :)
Thank you!

@taichikume
Copy link

taichikume commented Oct 5, 2018

I appreciate it very much but...Inspector is not working.
(e.g. Object Properties : color, border or some else)
Sure I know, it is hard work because, too many API has changed.

@luisalves73
Copy link

This worked! Thanks guys!

@MacAndor
Copy link
Author

MacAndor commented Oct 6, 2018

After some more testing we also found some issues, so it's more of a workaround than a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants