Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for issue 511 and 505 #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for issue 511 and 505 #516

wants to merge 1 commit into from
+8 −0

Conversation

jackiewu
Copy link

@jackiewu jackiewu commented Nov 8, 2018 •
edited
Loading

I found there are 4 items of layer.children();
image

but note only add two layers in a container(MSLayerGroup) at common.js (line: 1965-1981)
I can't figure out.
hope someone can solve this

I just solve my friend's problem let her export successfully

thanks~

related issues: #505, #511

@jackiewu jackiewu changed the title fix for issue 511 and 513 fix for issue 511 and 505 Nov 8, 2018
dannykeane
dannykeane approved these changes Nov 9, 2018
View reviewed changes
Copy link

@dannykeane dannykeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix solves the hanging issue when exporting files that contain notes.

@forestlin1212 forestlin1212 mentioned this pull request Nov 19, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykeane dannykeane dannykeane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackiewu @dannykeane