long size varchar with long index size mysql

.gitignore

@@ -8,6 +8,7 @@ loader.php
 /bin/view/results/
 .vscode
 .vscode/*
+database.sql
 
 ## - Oh Wess!
 Makefile

phpunit.xml

@@ -7,7 +7,7 @@
     convertNoticesToExceptions="true"
     convertWarningsToExceptions="true"
     processIsolation="false"
-    stopOnFailure="false">
+    stopOnFailure="true">
     <testsuites>
         <testsuite name="Application Test Suite">
             <directory>./tests/</directory>

src/Database/Adapter.php

@@ -476,9 +476,9 @@ abstract public function getKeywords(): array;
 
     /**
      * Filter Keys
-     * 
-     * @throws Exception
+     * @param string $value
      * @return string
+     * @throws Exception
      */
     public function filter(string $value): string
     {
@@ -490,4 +490,40 @@ public function filter(string $value): string
 
         return $value;
     }
+
+
+    /**
+     * Returns attribute from List of Document $attributes[]
+     * @param string $attributeKey
+     * @param array $attributes Document[]
+     * returns Document
+     * @return Document
+     * @throws Exception
+     */
+    protected function findAttributeInList(string $attributeKey, array $attributes): Document
+    {
+        /** @var Document $attribute */
+        foreach ($attributes as $attribute){
+           if($this->filter($attributeKey) === $this->filter($attribute->getId())){
+                return $attribute;
+            }
+        }
+
+        throw new \Exception('Attribute ' . $attributeKey . ' not found');
+    }
+
+    /**
+     * This function fixes indexes which have exceeded max default limits
+     * by comparing the length of the collection attribute string with index max length
+     * We can overwrite other index behaviour here.
+     *
+     * @param Document $index
+     * @param Document[] $attributes
+     * @return Document
+     * @throws Exception
+     */
+    public function fixIndex(Document $index, array $attributes): Document {
+        return $index;
+    }
+
 }

src/Database/Adapter/MariaDB.php

@@ -148,37 +148,41 @@ public function createCollection(string $name, array $attributes = [], array $in
         $database = $this->getDefaultDatabase();
         $namespace = $this->getNamespace();
         $id = $this->filter($name);
+        $schemaAttributes = [];
 
-        foreach ($attributes as $key => $attribute) {
+        foreach ($attributes as $attribute) {
             $attrId = $this->filter($attribute->getId());
-            $attrType = $this->getSQLType($attribute->getAttribute('type'), $attribute->getAttribute('size', 0), $attribute->getAttribute('signed', true));
+            $size = $attribute->getAttribute('size', 0);
+            $type = $attribute->getAttribute('type');
+            $signed = $attribute->getAttribute('signed', false);
+            $attrType = $this->getSQLType($type, $size, $signed);
 
             if ($attribute->getAttribute('array')) {
                 $attrType = 'LONGTEXT';
             }
 
-            $attributes[$key] = "`{$attrId}` {$attrType}, ";
+            $schemaAttributes[] = "`{$attrId}` {$attrType}, ";
         }
 
+        $schemaIndexes = [];
         foreach ($indexes as $key => $index) {
             $indexId = $this->filter($index->getId());
             $indexType = $index->getAttribute('type');
-
-            $indexAttributes = $index->getAttribute('attributes');
-            foreach ($indexAttributes as $nested => $attribute) {
-                $indexLength = $index->getAttribute('lengths')[$key] ?? '';
-                $indexLength = (empty($indexLength)) ? '' : '(' . (int)$indexLength . ')';
-                $indexOrder = $index->getAttribute('orders')[$key] ?? '';
+            $indexAttributes = [];
+            foreach ($index->getAttribute('attributes') as $attribute) {
                 $indexAttribute = $this->filter($attribute);
+                $size = $index['lengths'][$key] ?? 0;
+                $length = $size === 0 ? '' : '(' . $size . ')';
+                $indexOrder = $index->getAttribute('orders')[$key] ?? '';
 
                 if ($indexType === Database::INDEX_FULLTEXT) {
                     $indexOrder = '';
                 }
 
-                $indexAttributes[$nested] = "`{$indexAttribute}`{$indexLength} {$indexOrder}";
+                $indexAttributes[] = "`{$indexAttribute}`{$length} {$indexOrder}";
             }
 
-            $indexes[$key] = "{$indexType} `{$indexId}` (" . \implode(", ", $indexAttributes) . " ),";
+            $schemaIndexes[] = "{$indexType} `{$indexId}` (" . \implode(", ", $indexAttributes) . " ),";
         }
 
         try {
@@ -189,9 +193,9 @@ public function createCollection(string $name, array $attributes = [], array $in
                         `_createdAt` datetime(3) DEFAULT NULL,
                         `_updatedAt` datetime(3) DEFAULT NULL,
                         `_permissions` MEDIUMTEXT DEFAULT NULL,
-                        " . \implode(' ', $attributes) . "
+                        " . \implode(' ', $schemaAttributes) . "
                         PRIMARY KEY (`_id`),
-                        " . \implode(' ', $indexes) . "
+                        " . \implode(' ', $schemaIndexes) . "
                         UNIQUE KEY `_uid` (`_uid`),
                         KEY `_created_at` (`_createdAt`),
                         KEY `_updated_at` (`_updatedAt`)
@@ -368,7 +372,6 @@ public function deleteAttribute(string $collection, string $id, bool $array = fa
      * @param array $orders
      * @return bool
      * @throws Exception
-     * @throws PDOException
      */
     public function createIndex(string $collection, string $id, string $type, array $attributes, array $lengths, array $orders): bool
     {
@@ -1790,7 +1793,6 @@ protected function getSQLIndex(string $collection, string $id,  string $type, ar
 
             default:
                 throw new Exception('Unknown Index Type:' . $type);
-                break;
         }
 
         return "CREATE {$type} `{$id}` ON {$this->getSQLTable($collection)} ( " . implode(', ', $attributes) . " )";
@@ -1891,4 +1893,57 @@ public static function getPDOAttributes(): array
             PDO::ATTR_STRINGIFY_FETCHES => true // Returns all fetched data as Strings
         ];
     }
+
+    /**
+     * Return the maximum index length per attribute type
+     * @param int $size
+     * @param Document $attribute
+     * @return int
+     */
+    public function getDefaultIndexSize(int $size, Document $attribute): int
+    {
+        $maxIndexLength = 760;
+
+        if($attribute['type'] === Database::VAR_STRING){
+            if($attribute['size'] > $maxIndexLength){
+                $size = $size === 0 || $size > $maxIndexLength ? $maxIndexLength : $size;
+            }
+        }
+
+        return $size;
+    }
+
+
+    /**
+     * This function fixes indexes which has exceeded max default limits
+     * with comparing the length of the string length of the collection attribute
+     *
+     * @param Document $index
+     * @param Document[] $attributes
+     * @return Document
+     * @throws Exception
+     */
+    public function fixIndex(Document $index, array $attributes): Document {
+        foreach ($index->getAttribute('attributes') as $key => $indexAttribute) {
+
+            //Internal attributes do not have a real attribute
+            if(in_array($indexAttribute, ['$id', '$createdAt', '$updatedAt'])){
+                continue;
+            }
+
+            $attribute = $this->findAttributeInList($indexAttribute, $attributes);
+
+            $size = $index['lengths'][$key] ?? 0;
+            $max = 768; // 3072 divided by utf8mb4
+            if($attribute['type'] === Database::VAR_STRING){
+                if($attribute['size'] > $max){
+                    $index['lengths'][$key] = $size === 0 || $size > $max ? $max : $size;
+                }
+            }
+        }
+
+        return $index;
+    }
+
+
 }

src/Database/Adapter/SQLite.php

@@ -254,7 +254,6 @@ public function renameIndex(string $collection, string $old, string $new): bool
      * @param array $orders
      * @return bool
      * @throws Exception
-     * @throws PDOException
      */
     public function createIndex(string $collection, string $id, string $type, array $attributes, array $lengths, array $orders): bool
     {