Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove reference to godot activity in FmodSingleton.java #119

Merged
merged 2 commits into from
Jul 31, 2022

Conversation

piiertho
Copy link
Member

@piiertho piiertho commented Jul 15, 2022

This resolves #114
This resolves #124

@piiertho piiertho changed the title Draft; fix: remove reference to godot activity in FmodSingleton.java Draft: fix: remove reference to godot activity in FmodSingleton.java Jul 15, 2022
@piiertho piiertho changed the title Draft: fix: remove reference to godot activity in FmodSingleton.java fix: remove reference to godot activity in FmodSingleton.java Jul 15, 2022
@piiertho piiertho marked this pull request as draft July 15, 2022 10:17
@bitbrain
Copy link
Contributor

What is the rationale behind this change?

@piiertho
Copy link
Member Author

piiertho commented Jul 31, 2022

What is the rationale behind this change?

To adapt to changes on android side of godot. (This was not compiling before)

@piiertho piiertho marked this pull request as ready for review July 31, 2022 09:51
@bitbrain bitbrain merged commit d4ca0f4 into master Jul 31, 2022
bitbrain pushed a commit that referenced this pull request Jul 31, 2022
* fix: remove reference to godot activity in FmodSingleton.java

* fix: Change ANDROID_NDK_ROOT in CI to 21.4.7075529
@piiertho piiertho deleted the bugfix/android-export-plugin branch July 31, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android build is failing android build error "Activity cannot be converted to Godot"
2 participants