-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support extended google.api.annotations with response field #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need CI fix and a decision about running subtests individually.
go build -o main main.go | ||
vgo build -o main main.go | ||
|
||
test: build pwd clean protoc build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo - build
is used as first target
@@ -11,7 +7,7 @@ clean: | |||
find . -regex "\.\/.*\/.*\.go" -exec rm {} + | |||
rm -f main | |||
|
|||
protoc: | |||
protoc: protoc-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this protoc-build
in every sub-test - maybe it's better to run them once in the core Makefile.
And if you want to run a single test individually - just prepare your environment manually running make protoc-build
and then run make test
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or we could do even better and make 2 targets.
test
would explicitly run protoc-build
- you would use it in manuall run
test-ci
won't call protoc-build
- it would be used in the core Makefile to run all tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed verbally
cmd/protoc-gen-goclay/swagger.go
Outdated
@@ -4,7 +4,7 @@ import ( | |||
"github.com/golang/glog" | |||
plugin "github.com/golang/protobuf/protoc-gen-go/plugin" | |||
"github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway/descriptor" | |||
"github.com/utrack/grpc-gateway/protoc-gen-swagger/genswagger" | |||
"github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger/genswagger" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, then the swagger would break if clay
consumers won't use github.com/utrack/grpc-gateway
explicitly.
Maybe it's better to keep it as it is.
…pis/googleapis and google.golang.org/genproto
…eapis/googleapis and google.golang.org/genproto (part 2) - Support flags from fork https://github.com/doroginin/[email protected] - Optimize genSwaggerDef function
Now also supported repeated field in GET |
After this changes you can add binding with request/response mapping to repeated fields.
And in the result your request body will be:
["test","boo"]
and response body will be:["TEST","BOO"]