-
-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the default export? #370
Comments
Finally, an actual breaking change! ;-) (I'm fine with this since we've been actively discouraging people from using a default export since v3.) |
Cool! I only found out about this breaking change now while writing the TypeScript types, so it looks like you did a great job at discouraging it's use 😂! I will still add a note to the upgrading section in the readme though and will make sure that this breaking change appears in the CHANGELOG. |
BREAKING CHANGE: The default export, which used to be the v4() method but which was already discouraged in v3.x of this library, has been removed. Fixes #370
BREAKING CHANGE: The default export, which used to be the v4() method but which was already discouraged in v3.x of this library, has been removed. Fixes #370
I would recommend leaving a human readable exception in place for user experience. |
In
[email protected]
the Version 4 algorithm was exported as a default:In the current master this is no longer the case:
The minimum we should probably do is describe this in the README and in the CHANGELOG.
I could also try to use the data from https://github.com/tc39/proposal-uuid/tree/master/analysis in order to try to figure out how much of a breakage removing the default export would be?!
What do you think about this breaking change @broofa?
The text was updated successfully, but these errors were encountered: