Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting up two possible implementations of
uuidToBytes
for us to consider:uuidToBytes_concise
, is similar to what's onmaster
. Slightly better perf and compactness, pretty readable.uuidToBytes_fast
is @awwit's approach inv9
, but with thenumberToBytes
stuff done inline. Yields slightly better performance and saves a few bytes when minified. Not great readability (as tends to be the case with highly optimized code), hence the extra comments.Here are the numbers for the various flavors:
master
2v9
uuidToBytes_concise
uuidToBytes_fast
Thoughts? Pick one, I guess. :-)
uuidToBytes()
implementation run throughjsmin | gzip -c | wc -c
master
implementation does not currentlyvalidate()
like the other approaches mentioned here do.