Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ls --dired -R: fix the positions #5341

Merged
merged 10 commits into from
Oct 19, 2023
Merged

ls --dired -R: fix the positions #5341

merged 10 commits into from
Oct 19, 2023

Conversation

sylvestre
Copy link
Contributor

No description provided.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/ls/recursive. tests/ls/recursive is passing on 'main'. Maybe you have to rebase?

@sylvestre
Copy link
Contributor Author

GNU testsuite comparison:

GNU test failed: tests/ls/recursive. tests/ls/recursive is passing on 'main'. Maybe you have to rebase?

I can reproduce. I will have a look
should be just a if config.dired

@sylvestre sylvestre mentioned this pull request Oct 1, 2023
Merged
@sylvestre sylvestre force-pushed the fix-subdir branch 2 times, most recently from 2a38542 to b197b99 Compare October 1, 2023 15:58
cakebaker
cakebaker reviewed Oct 2, 2023
View reviewed changes
tests/by-util/test_ls.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 2, 2023
View reviewed changes
tests/by-util/test_ls.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 2, 2023
View reviewed changes
tests/by-util/test_ls.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 2, 2023
View reviewed changes
tests/by-util/test_ls.rs Outdated Show resolved Hide resolved
tertsdiepraam
tertsdiepraam reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to hit send on these comments :)

src/uu/ls/src/dired.rs Show resolved Hide resolved
src/uu/ls/src/dired.rs Outdated Show resolved Hide resolved
src/uu/ls/src/dired.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 3, 2023
View reviewed changes
src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 3, 2023
View reviewed changes
src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 3, 2023
View reviewed changes
src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved
@sylvestre
Copy link
Contributor Author

@cakebaker I think it is now ok :)

cakebaker
cakebaker reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though a rebase is needed.

@cakebaker cakebaker merged commit f971a69 into uutils:main Oct 19, 2023
42 of 45 checks passed
@chenrui333 chenrui333 mentioned this pull request Nov 14, 2023
Merged
@moonfruit moonfruit mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker approved these changes

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sylvestre @cakebaker @tertsdiepraam