Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split: suffix auto length #5433

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Conversation

zhitkoff
Copy link
Contributor

Refactor handling of automatically widening suffix length to pass GNU tests/split/suffix-auto-length.sh

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/split/suffix-auto-length is no longer failing!

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/split/suffix-auto-length is no longer failing!

@zhitkoff
Copy link
Contributor Author

found an edge case that is not covered by GNU test for suffix auto length, so the test passes, GNU split behavior is different - when the suffix length is specified in command line as 0, i.e. -a 0
Not sure why would anyone do that :) but working on the fix

@sylvestre
Copy link
Contributor

sylvestre commented Oct 22, 2023

Not sure why would anyone do that

I stopped asking me this question :)

@sylvestre sylvestre merged commit a3fed79 into uutils:main Oct 23, 2023
44 of 45 checks passed
@zhitkoff zhitkoff deleted the split-suffix-auto-length branch November 18, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants