mv: gnu test case `part-hardlink` fix #6632

matrixhead · 2024-08-11T09:29:05Z

fix for #6631

behaviours changed

mv will now preserve links during an inter-device move.
Previously, mv would silently fail to create a backup when no-target-directory was specified and the destination ended with a / This patch resolves that issue.
The progress bar will now work for simple inter-device file moves as well.

src/uu/mv/src/mv.rs

github-actions · 2024-08-11T09:49:27Z

GNU testsuite comparison:

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

src/uu/mv/src/mv.rs

tests/by-util/test_mv.rs

sylvestre · 2024-08-11T10:58:56Z

Bravo

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

github-actions · 2024-08-12T18:48:37Z

GNU testsuite comparison:

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

github-actions · 2024-08-12T19:08:22Z

GNU testsuite comparison:

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

github-actions · 2024-08-13T04:46:17Z

GNU testsuite comparison:

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

src/uu/mv/src/mv.rs

github-actions · 2024-08-14T04:30:58Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

BenWiederhake

Thank you for tackling these issues! However, combining these three behavioral changes seems like a bad idea, given that each of them have delicate consequences.

It seems that get_dir_content is the entirely wrong tool to approach mv, and it causes incorrect behavior.

Finally, it seems you fell into a common trap / bad pattern: Guessing a potential error condition (and not detecting others), then doing an action (and badly handling most error conditions.) This causes unhelpful error messages and unnecessary syscalls.

src/uu/mv/src/mv.rs

tests/by-util/test_mv.rs

src/uu/mv/src/mv.rs

BenWiederhake

Whoops, I meant to set the "Request changes" flag. See above for my reasoning. In particular, get_dir_content must go.

May I suggest to split the tree changes into two or three PRs?

github-actions · 2024-09-08T11:36:52Z

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

github-actions · 2024-09-11T08:13:46Z

GNU testsuite comparison:

GNU test failed: tests/mv/backup-dir. tests/mv/backup-dir is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

github-actions · 2024-09-11T08:49:03Z

GNU testsuite comparison:

GNU test failed: tests/mv/backup-dir. tests/mv/backup-dir is passing on 'main'. Maybe you have to rebase?

matrixhead · 2024-09-12T06:22:17Z

@BenWiederhake I cleaned up this PR. Now, it focuses solely on the directory copying part. I'll work on verbose output and error reporting next. For now, could you let me know if this approach looks okay?

github-actions · 2024-09-12T06:39:31Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

src/uu/mv/src/mv.rs

github-actions · 2024-09-12T09:44:23Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions · 2024-10-09T10:42:33Z

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/rm/rm2 is no longer failing!

github-actions · 2024-10-09T11:31:42Z

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/rm2 is no longer failing!

BenWiederhake · 2024-10-09T17:36:17Z

@matrixhead I'm unclear on how you wish to proceed. CI is green and ready to merge (assuming I would find no new issues in another review), but the PR is marked as "draft". You also keep force-pushing the branch, and I'm not sure whether you're introducing new changes each time, or just updating to latest master.

matrixhead · 2024-10-09T17:52:02Z

I'm sorry for all the force pushes. I was just trying to fix a bug in one of the tests I wrote, which I couldn't reproduce locally. I think everything is good now, and the PR is ready to merge, except for that one review I couldn't resolve.

matrixhead · 2024-10-21T12:36:08Z

Hi, sorry to be pushy, but it would be great to hear your thoughts on this 🙂

sylvestre · 2024-10-21T12:37:43Z

oh, please be pushy :)
i will have a look later today

Co-authored-by: Sylvestre Ledru <[email protected]>

github-actions · 2024-10-21T13:04:48Z

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

sylvestre reviewed Aug 11, 2024

View reviewed changes

src/uu/mv/src/mv.rs Outdated Show resolved Hide resolved

sylvestre requested a review from BenWiederhake August 11, 2024 09:31

sylvestre reviewed Aug 11, 2024

View reviewed changes

src/uu/mv/src/mv.rs Outdated Show resolved Hide resolved

sylvestre reviewed Aug 11, 2024

View reviewed changes

tests/by-util/test_mv.rs Show resolved Hide resolved

matrixhead force-pushed the part-hardlink branch from f32325e to 1da64ed Compare August 12, 2024 18:47

matrixhead force-pushed the part-hardlink branch from 1da64ed to 2c7bee1 Compare August 13, 2024 04:26

matrixhead requested a review from sylvestre August 13, 2024 04:47

sylvestre reviewed Aug 13, 2024

View reviewed changes

src/uu/mv/src/mv.rs Outdated Show resolved Hide resolved

matrixhead requested a review from sylvestre August 15, 2024 09:03

BenWiederhake mentioned this pull request Sep 7, 2024

mv: fails to create dir when missing read permissions #6684

Open

BenWiederhake reviewed Sep 7, 2024

View reviewed changes

BenWiederhake requested changes Sep 7, 2024

View reviewed changes

sylvestre force-pushed the part-hardlink branch from 4b9e64e to 666f8cb Compare September 8, 2024 11:17

matrixhead force-pushed the part-hardlink branch from 666f8cb to 119ce64 Compare September 11, 2024 07:47

sylvestre force-pushed the part-hardlink branch from 119ce64 to e8c9ffc Compare September 11, 2024 08:22

matrixhead marked this pull request as draft September 11, 2024 17:47

matrixhead force-pushed the part-hardlink branch from 3754a06 to 338ed28 Compare September 12, 2024 06:12

sylvestre reviewed Sep 12, 2024

View reviewed changes

src/uu/mv/src/mv.rs Outdated Show resolved Hide resolved

matrixhead force-pushed the part-hardlink branch from 660eb13 to 59f85e3 Compare October 9, 2024 10:16

matrixhead force-pushed the part-hardlink branch 2 times, most recently from d51d906 to 2c92015 Compare October 9, 2024 11:05

matrixhead requested a review from BenWiederhake October 9, 2024 15:48

matrixhead marked this pull request as ready for review October 9, 2024 17:52

matrixhead requested a review from sylvestre October 9, 2024 17:54

matrixhead and others added 16 commits October 21, 2024 14:37

mv: copy dir

62aa794

mv: gnu test backup-dir regression fix

51ea951

minor changes

4ef7a91

Update src/uu/mv/src/mv.rs

594711c

Co-authored-by: Sylvestre Ledru <[email protected]>

changed to MAIN_SEPARATOR

5af3a53

added verbose context type to print verbose message

7d24a03

mv: added dir copy error messages and types

87e462b

mv: tests and minor changes

b6cc389

mv: minor changes and unit tests

2a651ff

mv: interdevice metadata copying

33db109

mv: test and minor changes

87d02d9

mv: remove dir better error reporting

29a268d

mv: clippy lint errors

a639d4d

mv: only try to copy if inter-device move

c7689a8

mv: linting errors and minor changes

6b04236

mv: temp_fs test fix

d4c9ebf

sylvestre force-pushed the part-hardlink branch from 2c92015 to d4c9ebf Compare October 21, 2024 12:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mv: gnu test case `part-hardlink` fix #6632

mv: gnu test case `part-hardlink` fix #6632

matrixhead commented Aug 11, 2024

github-actions bot commented Aug 11, 2024

sylvestre commented Aug 11, 2024

github-actions bot commented Aug 12, 2024

github-actions bot commented Aug 12, 2024

github-actions bot commented Aug 13, 2024

github-actions bot commented Aug 14, 2024

BenWiederhake left a comment

BenWiederhake left a comment

github-actions bot commented Sep 8, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

matrixhead commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

BenWiederhake commented Oct 9, 2024

matrixhead commented Oct 9, 2024

matrixhead commented Oct 21, 2024

sylvestre commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

mv: gnu test case part-hardlink fix #6632

Are you sure you want to change the base?

mv: gnu test case part-hardlink fix #6632

Conversation

matrixhead commented Aug 11, 2024

github-actions bot commented Aug 11, 2024

sylvestre commented Aug 11, 2024

github-actions bot commented Aug 12, 2024

github-actions bot commented Aug 12, 2024

github-actions bot commented Aug 13, 2024

github-actions bot commented Aug 14, 2024

BenWiederhake left a comment

Choose a reason for hiding this comment

BenWiederhake left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 8, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

matrixhead commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Sep 12, 2024

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 9, 2024

BenWiederhake commented Oct 9, 2024

matrixhead commented Oct 9, 2024

matrixhead commented Oct 21, 2024

sylvestre commented Oct 21, 2024

github-actions bot commented Oct 21, 2024

mv: gnu test case `part-hardlink` fix #6632

mv: gnu test case `part-hardlink` fix #6632