Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printf: remove unused argument name from help #6807

Merged
merged 1 commit into from
Oct 21, 2024
Merged

printf: remove unused argument name from help #6807

merged 1 commit into from
Oct 21, 2024

Conversation

andrewliebenow
Copy link
Contributor

No description provided.

@andrewliebenow
Copy link
Contributor Author 

❯ coreutils printf --help | coreutils head -n 9
Print output based off of the format string and proceeding arguments.

Usage: coreutils printf FORMATSTRING [ARGUMENT]...
       coreutils printf FORMAT [ARGUMENT]...
       coreutils printf OPTION

Arguments:
  [FORMATSTRING]
  [ARGUMENT]...

"FORMATSTRING" and "FORMAT" are not two different arguments.

❯ /usr/bin/printf --help | coreutils head -n 2
Usage: /usr/bin/printf FORMAT [ARGUMENT]...
  or:  /usr/bin/printf OPTION

@sylvestre
Copy link
Contributor

lgtm but could you please update the commit msg to make it more explicit? thanks

@andrewliebenow
printf: remove unused argument name from help
d70990e 
printf --help is currently listing three usage forms:

```
Usage: coreutils printf FORMATSTRING [ARGUMENT]...
       coreutils printf FORMAT [ARGUMENT]...
       coreutils printf OPTION
```

But there are only two usage forms, since there is no difference
between "FORMAT" and "FORMATSTRING".

Remove references to "FORMATSTRING", and use "FORMAT" in all places
where "FORMATSTRING" appeared, since other implementations of
`printf` use the argument name "FORMAT".
@sylvestre sylvestre merged commit 8e6bf6a into uutils:main Oct 21, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewliebenow @sylvestre