Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uucore to 0.0.12 #132

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Update uucore to 0.0.12 #132

merged 1 commit into from
Jan 25, 2022

Conversation

refi64
Copy link
Contributor

@refi64 refi64 commented Jan 24, 2022

This version includes the needed filesystem type detection fix.

Signed-off-by: Ryan Gonzalez [email protected]

This version includes the needed filesystem type detection fix.

Signed-off-by: Ryan Gonzalez <[email protected]>
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #132 (949e76b) into main (1e67813) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   52.58%   52.72%   +0.14%     
==========================================
  Files          23       23              
  Lines        4650     4654       +4     
  Branches     1529     1531       +2     
==========================================
+ Hits         2445     2454       +9     
- Misses       1660     1664       +4     
+ Partials      545      536       -9     
Impacted Files Coverage Δ
src/lib.rs 35.92% <0.00%> (-0.02%) ⬇️
src/xargs/mod.rs 79.53% <0.00%> (+2.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e67813...949e76b. Read the comment docs.

@refi64
Copy link
Contributor Author

refi64 commented Jan 24, 2022

The test failure seems to be from something I never added to xargs still:

error: Found argument '-I' which wasn't expected, or isn't valid in this context

so I'm not sure why it's only failing now

@sylvestre
Copy link
Contributor

maybe the upstream testsuite has been updated?

@refi64
Copy link
Contributor Author

refi64 commented Jan 24, 2022

Looks like this was due to #133; when xargs was merged in, the tests regressed, and now the workflows are stuck comparing to the pre-xargs version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants