Fix a clippy warning #188
Merged
Fix a clippy warning #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`this expression borrows a value the compiler would automatically borrow`
Codecov Report
@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 50.05% 50.05%
=======================================
Files 30 30
Lines 4911 4911
Branches 1314 1318 +4
=======================================
Hits 2458 2458
Misses 1806 1806
Partials 647 647
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tavianator
reviewed
Oct 21, 2022
| @@ -206,7 +206,7 @@ impl FormatStringParser<'_> { | |||
| if digits > 0 { | |||
| // safe to unwrap: we already know all the digits are valid due to | |||
| // the above checks. | |||
| Some((&start[0..digits]).parse().unwrap()) | |||
| Some((start[0..digits]).parse().unwrap()) | |||
There was a problem hiding this comment.
The parentheses around (start[0..digits]) are also redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this expression borrows a value the compiler would automatically borrow