-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/timeout monitor fix #4386
Conversation
b7b0fa6
to
b4ca232
Compare
b4ca232
to
609518a
Compare
@ivan-c TODO rebase/switch to master before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks! had a minor nitpick, but no blockers
thanks for the helpful comments!
Co-authored-by: Ivan Cvitkovic <[email protected]>
1db43e4
to
3861234
Compare
I rebased this onto it should be ready to merge now; can you merge when you get a chance? thanks! |
Thank you @ivan-c It is merged. |
@sierramatice @achen2401 there were a couple commits Wednesday and it's not entirely clear to me... did Sie-Ce test Amy's latest refinements? |
@mcjustin hmm, I believe Sie-ce tested after all commits were made. Noting here that Sie-ce tested the Monday after. See Slack convo The last commit for this PR was this which occurred on Friday prior to Sie-ce's testing. |
address https://movember.atlassian.net/browse/IRONN-248
I was not able to reproduce and am still not certain how the issue occurred but the changes here might help:
tested the changes in my instance, session timed out as expected at configured time
TODO
git rebase HEAD~7 --onto master
; PR has 7 commits)