Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/timeout monitor fix #4386

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Feature/timeout monitor fix #4386

merged 7 commits into from
Jul 3, 2024

Conversation

achen2401
Copy link
Contributor

@achen2401 achen2401 commented Jun 27, 2024

address https://movember.atlassian.net/browse/IRONN-248

I was not able to reproduce and am still not certain how the issue occurred but the changes here might help:

  • as per suggestion from meeting today, add check for elapsed time (compared against session lifetime as configured) in timeout code before logging out user
  • add appropriate defaults (e.g. session lifetime) if for some reason, not available

tested the changes in my instance, session timed out as expected at configured time

TODO

  • @ivan-c rebase/switch to master before merging (git rebase HEAD~7 --onto master; PR has 7 commits)

@ivan-c ivan-c force-pushed the feature/timeout-monitor-fix branch from b7b0fa6 to b4ca232 Compare June 28, 2024 17:01
@ivan-c ivan-c changed the base branch from develop to feature/sequential-hard-triggers-fix June 28, 2024 17:01
@ivan-c ivan-c force-pushed the feature/timeout-monitor-fix branch from b4ca232 to 609518a Compare June 28, 2024 17:02
@ivan-c
Copy link
Member

ivan-c commented Jun 28, 2024

@ivan-c TODO rebase/switch to master before merging

Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! had a minor nitpick, but no blockers

thanks for the helpful comments!

portal/static/js/portal_wrapper/SessionMonitor.js Outdated Show resolved Hide resolved
Base automatically changed from feature/sequential-hard-triggers-fix to develop July 2, 2024 19:01
@mcjustin
Copy link
Member

mcjustin commented Jul 2, 2024

@ivan-c Today during the weekly w/ Mo we decided to deploy this as a hotfix this week, because opt-out may be delayed until mid-next week.
It has been tested by Sie-Ce per slack.

@ivan-c ivan-c force-pushed the feature/timeout-monitor-fix branch from 1db43e4 to 3861234 Compare July 3, 2024 15:19
@ivan-c ivan-c changed the base branch from develop to master July 3, 2024 15:19
@ivan-c
Copy link
Member

ivan-c commented Jul 3, 2024

@achen2401

I rebased this onto master for a hotfix (see PR description for git command), and changed the PR base to master

it should be ready to merge now; can you merge when you get a chance? thanks!

@achen2401 achen2401 merged commit fa8e6d2 into master Jul 3, 2024
1 of 2 checks passed
@achen2401 achen2401 deleted the feature/timeout-monitor-fix branch July 3, 2024 15:44
@achen2401
Copy link
Contributor Author

Thank you @ivan-c It is merged.

@mcjustin
Copy link
Member

mcjustin commented Jul 5, 2024

@ivan-c Today during the weekly w/ Mo we decided to deploy this as a hotfix this week, because opt-out may be delayed until mid-next week. It has been tested by Sie-Ce per slack.

@sierramatice @achen2401 there were a couple commits Wednesday and it's not entirely clear to me... did Sie-Ce test Amy's latest refinements?

@achen2401
Copy link
Contributor Author

@mcjustin hmm, I believe Sie-ce tested after all commits were made. Noting here that Sie-ce tested the Monday after. See Slack convo The last commit for this PR was this which occurred on Friday prior to Sie-ce's testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants