additional database indexes as per TN-3308

[pbugni]

Using the table in TN-3308 as a guide, pencil traced the code to find the common queries on each respective table.

I'd then assemble a query using flask shell to get the exact SQLAlchemy syntax, and then attempt before and after explain $query times, to confirm it would be of value.

Note the few in the migration that are directly added via SQL exec as the SQLAlchemy syntax didn't support (at least I couldn't find a way).

[pep8speaks]

Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file portal/migrations/versions/6120fcfc474a_add_missing_indexes.py:

Line 22:101: E501 line too long (133 > 100 characters)
Line 25:101: E501 line too long (105 > 100 characters)
Line 26:101: E501 line too long (115 > 100 characters)
Line 29:101: E501 line too long (127 > 100 characters)
Line 30:101: E501 line too long (123 > 100 characters)
Line 32:101: E501 line too long (107 > 100 characters)
Line 33:101: E501 line too long (119 > 100 characters)
Line 34:101: E501 line too long (105 > 100 characters)
Line 37:101: E501 line too long (132 > 100 characters)
Line 38:101: E501 line too long (133 > 100 characters)
Line 39:101: E501 line too long (112 > 100 characters)
Line 47:101: E501 line too long (102 > 100 characters)
Line 48:101: E501 line too long (104 > 100 characters)

Comment last updated at 2024-08-08 23:54:42 UTC

[ivan-c]

looks good, thanks!

I re-ran the seq_vs_idx query again and most of the highest-ranked offenders are dealt with in this PR, except user_observations, which is now #1

         relname         | seq_vs_idx | seq_scan | idx_scan  | rel_size  |     hint      
-------------------------+------------+----------+-----------+-----------+---------------
 user_observations       |   12243365 | 12243365 |         0 |    663552 | Check indexes
 questionnaire_responses |    5651062 |  5950648 |    299586 | 130998272 | Check indexes
 encounter_codings       |    1907006 |  1907006 |         0 |   4161536 | Check indexes
 encounters              |    1586471 |  3540200 |   1953729 |  88932352 | Check indexes
 tou                     |      49417 |    49417 |         0 |   2260992 | Check indexes

[pbugni]

Thank you @ivan-c , great catch on the user_observations table.