Skip to content

Maintenance: doc comments, public fields => properties. #1309

Maintenance: doc comments, public fields => properties.

Maintenance: doc comments, public fields => properties. #1309

Triggered via push September 26, 2024 21:03
Status Success
Total duration 8m 20s
Artifacts 3

reko.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

38 warnings
build (ubuntu-latest)
Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
build (ubuntu-latest)
- Add lib or ref assemblies for the net8.0 target framework
build (ubuntu-latest): src/Decompiler/Analysis/FpuStackReturnGuesser.cs#L81
Field 'FpuStackReturnGuesser.Worker.changed' is never assigned to, and will always have its default value false
build (ubuntu-latest): src/Decompiler/Scanning/FetFinder.cs#L53
The field 'FetFinder.uAddrMin' is never used
build (ubuntu-latest): src/Decompiler/Scanning/FetFinder.cs#L52
The field 'FetFinder.uAddrMax' is never used
build (ubuntu-latest): src/Environments/PalmOS/Traps.cs#L1415
The variable 'output' is assigned but its value is never used
build (ubuntu-latest): src/Environments/C64/C64BasicRewriter.cs#L552
'RtlEmitter.If(Expression, RtlInstruction)' is obsolete: 'RtlIf is going away soon: don't use it.'
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/Services/AvaloniaEventListener.cs#L49
Non-nullable field 'cancellationSvc' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/Services/AvaloniaServiceFactory.cs#L164
Possible null reference argument for parameter 'treeView' in 'ProjectBrowserService.ProjectBrowserService(IServiceProvider services, ITabPage tabPage, ITreeView treeView)'.
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/Services/AvaloniaEventListener.cs#L81
Possible null reference argument for parameter 'addrVector' in 'JumpVectorNavigator.JumpVectorNavigator(IReadOnlyProgram program, IProcessorArchitecture arch, Address addrInstr, Address addrVector, int stride, IServiceProvider services)'.
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/ViewModels/AvaloniaTextSpanFactory.cs#L172
Non-nullable property 'Address' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
build (ubuntu-latest): src/UserInterfaces/AvaloniaUI/Controls/VisualizerControl.cs#L119
Non-nullable field 'services' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build (macos-13): src/Environments/C64/C64BasicRewriter.cs#L552
'RtlEmitter.If(Expression, RtlInstruction)' is obsolete: 'RtlIf is going away soon: don't use it.'
build (macos-13): src/Decompiler/Scanning/FetFinder.cs#L52
The field 'FetFinder.uAddrMax' is never used
build (macos-13): src/Decompiler/Analysis/FpuStackReturnGuesser.cs#L81
Field 'FpuStackReturnGuesser.Worker.changed' is never assigned to, and will always have its default value false
build (macos-13): src/Decompiler/Scanning/FetFinder.cs#L53
The field 'FetFinder.uAddrMin' is never used
build (macos-13): src/Environments/PalmOS/Traps.cs#L1415
The variable 'output' is assigned but its value is never used
build (macos-13): src/UserInterfaces/AvaloniaUI/Controls/VisualizerControl.cs#L119
Non-nullable field 'services' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build (macos-13): src/UserInterfaces/AvaloniaUI/Controls/VisualizerControl.cs#L119
Non-nullable field 'addrTopVisible' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build (macos-13): src/UserInterfaces/AvaloniaUI/Controls/VisualizerControl.cs#L194
Possible null reference argument for parameter 'a' in 'Address Address.operator +(Address a, ulong off)'.
build (macos-13): src/UserInterfaces/AvaloniaUI/Services/AvaloniaUiPreferencesService.cs#L162
Possible null reference argument for parameter 'hex' in 'Color AvaloniaUiPreferencesService.GetColor(string hex)'.
build (macos-13): src/UserInterfaces/AvaloniaUI/Services/AvaloniaUiPreferencesService.cs#L163
Possible null reference argument for parameter 'hex' in 'Color AvaloniaUiPreferencesService.GetColor(string hex)'.
build (macos-13)
Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
build (macos-13)
- Add lib or ref assemblies for the net8.0 target framework
build (macos-13)
pkg-config 0.29.2_3 is already installed and up-to-date. To reinstall 0.29.2_3, run: brew reinstall pkg-config
build (windows-latest)
Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:
build (windows-latest)
- Add lib or ref assemblies for the net8.0 target framework
build (windows-latest): src/Environments/C64/C64BasicRewriter.cs#L552
'RtlEmitter.If(Expression, RtlInstruction)' is obsolete: 'RtlIf is going away soon: don't use it.'
build (windows-latest): src/Decompiler/Analysis/FpuStackReturnGuesser.cs#L81
Field 'FpuStackReturnGuesser.Worker.changed' is never assigned to, and will always have its default value false
build (windows-latest): src/Decompiler/Scanning/FetFinder.cs#L52
The field 'FetFinder.uAddrMax' is never used
build (windows-latest): src/Decompiler/Scanning/FetFinder.cs#L53
The field 'FetFinder.uAddrMin' is never used
build (windows-latest): src/Environments/PalmOS/Traps.cs#L1415
The variable 'output' is assigned but its value is never used
build (windows-latest): src/UserInterfaces/WindowsForms/Controls/MemoryControl.cs#L75
Field 'MemoryControl.yTopRow' is never assigned to, and will always have its default value 0
build (windows-latest): src/UserInterfaces/AvaloniaUI/Controls/VisualizerControl.cs#L119
Non-nullable field 'services' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build (windows-latest): src/UserInterfaces/AvaloniaUI/Controls/VisualizerControl.cs#L119
Non-nullable field 'addrTopVisible' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build (windows-latest): src/UserInterfaces/AvaloniaUI/Controls/VisualizerControl.cs#L194
Possible null reference argument for parameter 'a' in 'Address Address.operator +(Address a, ulong off)'.
build (windows-latest): src/UserInterfaces/AvaloniaUI/Controls/TextViewPainter.cs#L56
Non-nullable field 'selStart' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build (windows-latest): src/Installers/WixInstaller/Product.wxs#L63
ICE69: Mismatched component reference. Entry 'ApplicationStartMenuShortcut' of the Shortcut table belongs to component 'ApplicationShortcut'. However, the formatted string in column 'Target' references file 'WindowsDecompiler.exe' which belongs to component 'ProductComponent'. Components are in the same feature.

Artifacts

Produced during runtime
Name Size
reko-macos-13
32.2 MB
reko-ubuntu-latest
32.3 MB
reko-windows-latest
73.2 MB