sonar issues

uyuni-project · Jun 21, 2024 · a7dfe4b · a7dfe4b
1 parent 1b762d2
commit a7dfe4b
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 11 deletions.
diff --git a/java/code/src/com/redhat/rhn/common/ErrorReportingStrategies.java b/java/code/src/com/redhat/rhn/common/ErrorReportingStrategies.java
@@ -40,7 +40,7 @@ private ErrorReportingStrategies() {
      * @return Supplier of RhnRuntimeException that logs the message and throw the exception
      */
     public static Supplier<RhnRuntimeException> raiseAndLog(Object obj, String message) {
-        Logger logger = OBJ_LOGGER.computeIfAbsent(obj, (key) -> LogManager.getLogger(obj.getClass().getName()));
+        Logger logger = OBJ_LOGGER.computeIfAbsent(obj, key -> LogManager.getLogger(obj.getClass().getName()));
         return () -> {
             logger.error(message);
             return new RhnRuntimeException(message);

diff --git a/java/code/src/com/redhat/rhn/manager/system/SystemManager.java b/java/code/src/com/redhat/rhn/manager/system/SystemManager.java
@@ -145,7 +145,6 @@
 import org.apache.logging.log4j.Logger;
 import org.hibernate.Session;
 
-import java.io.IOException;
 import java.net.IDN;
 import java.security.SecureRandom;
 import java.sql.Date;
@@ -2155,7 +2154,7 @@ public byte[] createProxyContainerConfig(User user, String proxyName, Integer pr
                                              SSLCertPair proxyCertKey,
                                              SSLCertPair caPair, String caPassword, SSLCertData certData,
                                              SSLCertManager certManager)
-            throws IOException, InstantiationException, SSLCertGenerationException {
+            throws SSLCertGenerationException {
 
         return new ProxyContainerConfigCreate().create(
                 saltApi, systemEntitlementManager, user, server, proxyName, proxyPort, maxCache, email,

diff --git a/.../redhat/rhn/manager/system/proxycontainerconfig/ProxyContainerConfigCreateAcquisitor.java b/.../redhat/rhn/manager/system/proxycontainerconfig/ProxyContainerConfigCreateAcquisitor.java
@@ -39,8 +39,6 @@
 import com.suse.manager.webui.services.impl.runner.MgrUtilRunner;
 
 import org.apache.commons.lang3.RandomStringUtils;
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
 
 import java.security.SecureRandom;
 import java.util.HashSet;
@@ -53,7 +51,6 @@
  * Acquires and validates all necessary data for the Proxy container configuration creation files.
  */
 public class ProxyContainerConfigCreateAcquisitor implements ProxyContainerConfigCreateContextHandler {
-    private static final Logger LOG = LogManager.getLogger(SystemManagerUtils.class);
 
     private SaltApi saltApi;
 

diff --git a/...com/redhat/rhn/manager/system/proxycontainerconfig/ProxyContainerConfigCreateContext.java b/...com/redhat/rhn/manager/system/proxycontainerconfig/ProxyContainerConfigCreateContext.java
@@ -25,9 +25,6 @@
 import com.suse.manager.webui.services.iface.SaltApi;
 import com.suse.manager.webui.services.impl.runner.MgrUtilRunner;
 
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
-
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -37,8 +34,6 @@
  */
 public class ProxyContainerConfigCreateContext {
 
-    private static final Logger LOG = LogManager.getLogger(ProxyContainerConfigCreateContext.class);
-
     // provided
     private final SaltApi saltApi;
     private final User user;