Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci add gh actions acceptance tests coverage #8929

Closed
wants to merge 26 commits into from
Closed

Ci add gh actions acceptance tests coverage #8929

wants to merge 26 commits into from

Conversation

jordimassaguerpla
Copy link
Contributor

What does this PR change?

This adds extra coverage into the acceptance tests run in github actions.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • No tests

  • DONE

Links

Issue(s):
https://github.com/SUSE/spacewalk/issues/24433
https://github.com/SUSE/spacewalk/issues/23654
https://github.com/SUSE/spacewalk/issues/23593
https://github.com/SUSE/spacewalk/issues/20962
https://github.com/SUSE/spacewalk/issues/20958
https://github.com/SUSE/spacewalk/issues/20955
https://github.com/SUSE/spacewalk/issues/20670
https://github.com/SUSE/spacewalk/issues/20954
https://github.com/SUSE/spacewalk/issues/20678
https://github.com/SUSE/spacewalk/issues/20677
https://github.com/SUSE/spacewalk/issues/20670

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8929/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8929/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

jordimassaguerpla and others added 24 commits June 20, 2024 15:57
Otherwise creates a lot of noise.
Scheduled actions are meant for upstream, as reference jobs to compare
the results of your Pull Request.

Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
We need ansible and prometheus packages preinstalled in the images. This
way, we do not depend on installing the packages from external infrastructure.

Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
Signed-off-by: Jordi Massaguer Pla <[email protected]>
@jordimassaguerpla
Copy link
Contributor Author

imatge

This is the error I am having. Seems I miss a definition of the build path ... but how can I set that? @nodeg any idea?

@jordimassaguerpla
Copy link
Contributor Author

jordimassaguerpla commented Jul 1, 2024

Comparing this to running tests on master with jenkins, we are increasing the coverage from 40% to 47% with this PR. Meaning, without this PR we run 40% of the tests we run on master with jenkins, thus we are increasing 7% the coverage with this PR.

Tests that we skip include tests that require SCC or PXE/DHCP. For example, we do not run any test related to reposync or retail.

Just for the record, in master with jenkins (podman version), we run 7628 tests.
Without this PR, we run 3033. With this PR, we run 3581.

@jordimassaguerpla jordimassaguerpla closed this by deleting the head repository Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment