Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt packages to check for modifications #8959

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Jun 20, 2024

What does this PR change?

The list of packages to check for compliance was wrong.

  • python311-azure-mgmt-billing was removed as it is not on the image anymore
  • python-instance-billing-flavor-check was added as it tells us if we are PAYG or not

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Issue(s):

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@mcalmer mcalmer requested a review from a team as a code owner June 20, 2024 08:19
@mcalmer mcalmer requested review from agraul and removed request for a team June 20, 2024 08:19
agraul
agraul previously approved these changes Jun 20, 2024
Copy link
Member

@agraul agraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would put all packages to check in a list and do

>>> packages_modified = any(has_package_modifications(pkg) for pkg in ["python-instance-billing-flavor-check", "csp-billing-adapter-service", ...])
>>> packages_modified
True

@mcalmer
Copy link
Contributor Author

mcalmer commented Jun 20, 2024

@admd @deneb-alpha I added this to the resubmission candidates.

@admd admd merged commit 36dc339 into uyuni-project:master Jun 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants