Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sls backup creation as directory with spacecmd (bsc#1230745) #9294

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

vzhestkov
Copy link
Contributor

What does this PR change?

Fixes broken spacecmd configchannel_backup, in case of calling backup for state channel sls files are created as empty directories instead of files.

GUI diff

No difference.

Before:

After:

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: old feature seems has no tests for it and was broken for a long time.

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/25267
Port(s): https://github.com/SUSE/spacewalk/pull/25328 https://github.com/SUSE/spacewalk/pull/25327

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@vzhestkov vzhestkov requested a review from a team as a code owner September 26, 2024 07:47
@vzhestkov vzhestkov requested review from m-czernek and removed request for a team September 26, 2024 07:47
@vzhestkov vzhestkov added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Sep 26, 2024
Copy link
Contributor

@m-czernek m-czernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@deneb-alpha deneb-alpha merged commit 34ca1eb into uyuni-project:master Sep 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-candidate Meaning it needs to be considered for merging when the master branch is frozen python3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants