mark dmidecode and logrotate as optional for Liberty 7 LTSS #9341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agraul
reviewed
Oct 10, 2024
| @@ -103,11 +103,11 @@ | |||
| ] | |||
|
|
|||
| RES7 = [ | |||
| "logrotate", | |||
| "logrotate*", | |||
There was a problem hiding this comment.
logrotate is not an optional dependency for the Bundle, see e.g. https://build.suse.de/projects/SUSE:Maintenance:35074/packages/venv-salt-minion.SUSE_RES-7_Update_Products_SaltBundle_Update/repositories/SUSE_RES-7_Update_Products_SaltBundle_Update/binaries/x86_64/venv-salt-minion-3006.0-2.58.1.x86_64.rpm
There was a problem hiding this comment.
yes, but RES7 LTSS repo does not provide that package. It result always in build errors.
As I think logrotate is in 99% of all the cases already installed, I would vote for this shortcut.
It only effect RES7 which is LTSS. By the rules no, new installation should happen for LTSS versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Mark additional packages as optional.
Liberty 7 LTSS for OL do not have all the packages in the repo and generating the bootstrap repo fails for this.
With marking them optional they can be ignored without producing error messages.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: already covered
DONE
Links
Port(s): https://github.com/SUSE/spacewalk/pull/25485
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!