Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscription matching warning layout #9351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Etheryte
Copy link
Member

@Etheryte Etheryte commented Oct 11, 2024

What does this PR change?

See GUI diff.

GUI diff

Before:

Screenshot 2024-10-11 at 14 17 20

After:

Screenshot 2024-10-11 at 14 15 46
  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: layout update

  • DONE

Links

Related discussion: https://suse.slack.com/archives/C02D78LLS04/p1728636748424919

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9351/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9351/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

Suggested tests to cover this Pull Request
  • srv_task_status_engine
  • srv_restart
  • min_rhlike_openscap_audit
  • srv_organization_credentials
  • srv_cobbler_buildiso
  • srv_cobbler_sync
  • min_salt_openscap_audit
  • minssh_salt_install_package
  • min_rhlike_monitoring
  • srv_osimage
  • buildhost_docker_build_image
  • srv_power_management_api
  • min_config_state_channel
  • minssh_tunnel
  • srv_payg_ssh_connection
  • min_deblike_openscap_audit
  • min_rhlike_ssh
  • srv_add_rocky8_repositories
  • min_check_patches_install
  • buildhost_osimage_build_image
  • srv_mainpage
  • proxy_retail_pxeboot_and_mass_import
  • srv_sync_fake_channels
  • min_empty_system_profiles
  • srv_user_configuration_salt_states
  • min_retracted_patches
  • srv_delete_channel_from_ui
  • min_salt_user_states
  • min_custom_pkg_download_endpoint
  • proxy_container_cobbler_pxeboot
  • min_bootstrap_script
  • min_deblike_salt_install_with_staging
  • srv_create_activationkey
  • minssh_action_chain
  • min_salt_pkgset_beacon
  • srv_datepicker
  • min_change_software_channel
  • min_ssh_tunnel
  • srv_first_settings
  • srv_salt
  • srv_patches_page
  • allcli_overview_systems_details
  • srv_content_lifecycle
  • srv_manage_channels_page
  • min_salt_minion_details
  • srv_distro_cobbler
  • srv_channels_add
  • srv_advanced_search
  • min_salt_software_states
  • min_cve_audit
  • srv_clone_channel_npn
  • srv_monitoring
  • min_salt_install_package
  • min_bootstrap_reactivation
  • srv_cobbler_distro
  • min_action_chain
  • srv_sync_channels
  • min_config_state_channel_subscriptions
  • srv_sync_products
  • min_salt_install_with_staging
  • srv_power_management
  • srv_check_sync_source_packages
  • min_salt_migration
  • proxy_traditional_retail_mass_import
  • allcli_software_channels
  • min_salt_formulas_advanced
  • min_salt_mgrcompat_state
  • sle_ssh_minion
  • sle_minion
  • proxy_as_pod_basic_tests
  • min_rhlike_salt_install_package_and_patch
  • srv_create_fake_channels
  • srv_scc_user_credentials
  • proxy_traditional_retail_pxeboot
  • srv_check_channels_page
  • min_move_from_and_to_proxy
  • srv_docker_advanced_content_management
  • allcli_update_activationkeys
  • min_bootstrap_ssh_key
  • srv_change_password
  • srv_disable_local_repos_off
  • min_salt_minions_page
  • srv_docker_cve_audit
  • min_salt_lock_packages
  • srv_power_management_redfish
  • min_deblike_remote_command
  • proxy_container_branch_network
  • srv_notifications
  • srv_disable_scheduled_reposync
  • allcli_software_channels_dependencies
  • min_ansible_control_node
  • srv_group_union_intersection
  • srv_rename_hostname
  • srv_users
  • allcli_system_group
  • min_docker_api
  • min_project_lotus
  • buildhost_docker_auth_registry
  • allcli_reboot
  • allcli_action_chain
  • buildhost_bootstrap
  • srv_dist_channel_mapping
  • proxy_register_as_minion_with_script
  • srv_menu
  • min_deblike_salt_install_package
  • allcli_config_channel
  • srv_user_preferences
  • srv_handle_software_channels_with_ISS_v2
  • min_deblike_salt
  • srv_check_reposync
  • srv_handle_config_channels_with_ISS_v2
  • min_bootstrap_negative
  • srv_create_repository
  • min_deblike_ssh
  • srv_logfile
  • min_bootstrap_api
  • srv_push_package
  • min_rhlike_salt
  • srv_salt_download_endpoint
  • srv_maintenance_windows
  • srv_channel_api
  • min_monitoring
  • proxy_branch_network
  • srv_delete_channel_with_tool
  • min_virthost
  • min_activationkey
  • srv_activationkey_api
  • minkvm_guests
  • proxy_traditional_cobbler_pxeboot
  • min_deblike_monitoring
  • min_salt_formulas
  • minssh_move_from_and_to_proxy
  • min_rhlike_remote_command
  • srv_reportdb
  • minssh_bootstrap_api
  • proxy_traditional
  • proxy_container_retail_mass_import
  • min_timezone
  • srv_create_fake_repositories
  • srv_change_task_schedule
  • srv_cobbler_profile
  • min_cve_id_new_syntax
  • srv_enable_sync_products
  • min_recurring_action

@Etheryte Etheryte marked this pull request as ready for review October 11, 2024 12:30
@Etheryte Etheryte requested review from a team as code owners October 11, 2024 12:30
@Etheryte Etheryte requested review from nadvornik, cbbayburt and admd and removed request for a team October 11, 2024 12:30
@Etheryte
Copy link
Member Author

@cbbayburt I'm not familiar with the whole templating logic around these Java classes, is there anything else that needs to be updated to match? The change works fine when testing locally, simply not sure if anything else related to NotificationData needs to be changed.

Copy link
Contributor

@cbbayburt cbbayburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it myself, but these notification items are also used in other places like the notification page (bell icon on the top right) and daily email reports.

You might wanna check how the longer summary displays in those places too.

A safer alternative might be to keep "summary" and "details" as is, but use only "details" in the landing page.

@Etheryte
Copy link
Member Author

Thanks, I was not aware of that. Yes, I think that way makes more sense in that case, I will make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants