refactor: remove setRequired and isRequired as unnecessary

vaadin · Apr 16, 2024 · f12b455 · f12b455
1 parent a111640
commit f12b455
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 44 deletions.
diff --git a/...arent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox/Checkbox.java b/...arent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox/Checkbox.java
@@ -68,7 +68,6 @@ public class Checkbox extends AbstractSinglePropertyField<Checkbox, Boolean>
     private String ariaLabel;
     private String ariaLabelledBy;
 
-    private boolean required;
     private boolean manualValidationEnabled = false;
 
     /**
@@ -323,34 +322,6 @@ public boolean isIndeterminate() {
         return getElement().getProperty("indeterminate", false);
     }
 
-    /**
-     * Sets whether the checkbox is marked as input required.
-     *
-     * @since 24.5
-     * @param required
-     *            the boolean value to set
-     */
-    public void setRequired(boolean required) {
-        getElement().setProperty("required", required);
-        this.required = required;
-    }
-
-    /**
-     * Determines whether the checkbox is marked as input required.
-     *
-     * @since 24.5
-     * @return {@code true} if the input is required, {@code false} otherwise
-     */
-    public boolean isRequired() {
-        return getElement().getProperty("required", false);
-    }
-
-    @Override
-    public void setRequiredIndicatorVisible(boolean requiredIndicatorVisible) {
-        super.setRequiredIndicatorVisible(requiredIndicatorVisible);
-        this.required = requiredIndicatorVisible;
-    }
-
     @Override
     public void setManualValidation(boolean enabled) {
         this.manualValidationEnabled = enabled;
@@ -373,8 +344,9 @@ protected void validate() {
      * constraints using browser development tools.
      */
     private boolean isInvalid(Boolean value) {
+        boolean isRequired = isRequiredIndicatorVisible();
         ValidationResult requiredValidation = ValidationUtil
-                .checkRequired(required, value, getEmptyValue());
+                .checkRequired(isRequired, value, getEmptyValue());
 
         return requiredValidation.isError();
     }

diff --git a/...heckbox-flow/src/test/java/com/vaadin/flow/component/checkbox/tests/CheckboxUnitTest.java b/...heckbox-flow/src/test/java/com/vaadin/flow/component/checkbox/tests/CheckboxUnitTest.java
@@ -150,20 +150,6 @@ public void setAriaLabelledBy() {
         Assert.assertTrue(checkbox.getAriaLabelledBy().isEmpty());
     }
 
-    @Test
-    public void setRequired_isRequired() {
-        Checkbox checkbox = new Checkbox();
-
-        Assert.assertFalse(checkbox.isRequired());
-        Assert.assertFalse(
-                checkbox.getElement().getProperty("required", false));
-
-        checkbox.setRequired(true);
-
-        Assert.assertTrue(checkbox.isRequired());
-        Assert.assertTrue(checkbox.getElement().getProperty("required", false));
-    }
-
     @Test
     public void implementsInputField() {
         Checkbox field = new Checkbox();