Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add MenuBar.close() #5745

Merged
merged 8 commits into from
Jan 24, 2024
Merged

feat: add MenuBar.close() #5745

merged 8 commits into from
Jan 24, 2024

Conversation

mvysny
Copy link
Member

@mvysny mvysny commented Nov 21, 2023 •
edited
Loading

Description

add MenuBar.close() which allows us to build a PopupButton easily on top of MenuBar. Also allows you to have menu items different than <vaadin-menu-item>, which also close the MenuBar upon clicking (requires a manual click listener + calling close()).

Fixes #5742

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@tomivirkki tomivirkki changed the title feat: add MenuBar.close(). Fixes #5742 feat: add MenuBar.close() Nov 24, 2023
tomivirkki
tomivirkki previously requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@tomivirkki tomivirkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge for now since this might still need some more internal discussion

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
Copy link
Contributor

PR for adding public API to web component: vaadin/web-components#7102

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sissbruecker sissbruecker dismissed tomivirkki’s stale review January 24, 2024 14:29

Comments have been addressed

@sissbruecker sissbruecker merged commit e1a546b into main Jan 24, 2024
5 checks passed
@sissbruecker sissbruecker deleted the feat/5742 branch January 24, 2024 14:29
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

@tomivirkki tomivirkki Awaiting requested review from tomivirkki

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MenuBar.close()
4 participants
@mvysny @sissbruecker @vaadin-bot @tomivirkki