Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make MessageInput implement Focusable #6259

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #6243

Note: this will only make focus() work once vaadin/web-components#7364 is released.

Also, there will be problems with addFocusListener like the one we have in DateTimePicker, see #2284

Type of change

  • Feature

@web-padawan web-padawan force-pushed the feat/message-input-focusable branch from be9d472 to f55252b Compare May 2, 2024 07:02
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sissbruecker sissbruecker merged commit f60daad into main Jun 14, 2024
5 checks passed
@sissbruecker sissbruecker deleted the feat/message-input-focusable branch June 14, 2024 07:42
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha3 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageInput is not implementing Focusable.
3 participants