fix: output version string when version parsing fails (#12530)

This should ease debugging of problems like "UnknownVersionException: Unable to detect version of pnpm"
vaadin · Dec 10, 2021 · 092578e · 092578e
1 parent 5ec8ddd
commit 092578e
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java b/flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java
@@ -975,13 +975,23 @@ public CommandExecutionException(Throwable cause) {
 
     protected static FrontendVersion getVersion(String tool,
             List<String> versionCommand) throws UnknownVersionException {
+        String output;
         try {
-            String output = executeCommand(versionCommand);
-            return new FrontendVersion(parseVersionString(output));
-        } catch (IOException | CommandExecutionException e) {
+            output = executeCommand(versionCommand);
+        } catch (CommandExecutionException e) {
             throw new UnknownVersionException(tool,
                     "Using command " + String.join(" ", versionCommand), e);
         }
+
+        try {
+            return new FrontendVersion(parseVersionString(output));
+        } catch (IOException e) {
+            throw new UnknownVersionException(tool,
+                    "Expected a version number as output but got '" + output
+                            + "'" + " when using command "
+                            + String.join(" ", versionCommand),
+                    e);
+        }
     }
 
     /**