TaskCopyLocalFrontendFiles#copyLocalResources(File, File, String... ) takes a long time using Windows-OS #19866
Comments
mshabarov
moved this to Inbox (needs triage)
in Vaadin Flow enhancements backlog (Vaadin 10+)
github-project-automation
bot
moved this from Inbox (needs triage)
to Done / Pending Release
in Vaadin Flow enhancements backlog (Vaadin 10+)
vaadin-bot
added a commit
that referenced
this issue
Sep 6, 2024
…g of time (#19894) (#19906) Allows to skip setting writable flag on copied files by providing the vaadin.frontend.disableWritableFlagCheckOnCopy system property. This may improve performance in certain scenarios with Windows OS. Fixes #19866 Co-authored-by: Tatu Lund <[email protected]>
|
This ticket/PR has been released with Vaadin 24.5.0.alpha16 and is also targeting the upcoming stable 24.5.0 version. |
|
This ticket/PR has been released with Vaadin 24.4.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
I'm using a windows pc and have noticed, that starting up our app takes longer than my colleges with mac.
The method com.vaadin.flow.server.frontend.TaskCopyLocalFrontendFiles#copyLocalResources takes up to a minute on windows and only 5 seconds on OSX.
We have found out, that the part that takes long ist what was added with #12711 . To be precise the code lines:
try (Stream<Path> fileStream = Files .walk(Paths.get(target.getPath()))) { // used with try-with-resources as defined in walk API note fileStream.filter(file -> !Files.isWritable(file)).forEach( filePath -> filePath.toFile().setWritable(true)); }Expected behavior
Could you please add an option/property to deactive the functionality of setting all files writeable.
None of our files are readonly and this is costing our developers lots of time.
Minimal reproducible example
not sure
Versions
The text was updated successfully, but these errors were encountered: