Bump TypeScript to 4.5.3 #12562
Merged
Bump TypeScript to 4.5.3 #12562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Are there incompatible changes in TS 4.5 that need to be taken into account somewhere? |
|
@Artur- I'm not aware of any. Generally TS 4.5 seems to have less breaking changes compared to what 4.4 had. https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-5.html#breaking-changes If something related to those breaks, I assume it should be easy to fix. |
Artur-
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer has been using
this.shadowRoot?.elementFromPointmethod which got broken in TS 4.4 (Vaadin 21) due to lib DOM type definition changes. In V22 with TS 4.4 it requires additional casting workaround to be able to call that method. This should be resolved by upgrading to TS 4.5 (change in TS). Related: WICG/webcomponents#661 (comment)