feat: add default I18N provider bean for Spring #17933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 025 files + 8 1 025 suites +8 1h 2m 6s ⏱️ - 4m 51s Results for commit 8c31155. ± Comparison against base commit 76f5fcd. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Just noticed that Logger instance field is not needed anymore so I'll remove that. |
caalador
reviewed
Oct 27, 2023
vaadin-spring/src/main/java/com/vaadin/flow/spring/i18n/DefaultI18NProviderFactory.java
Outdated
Show resolved
Hide resolved
vaadin-spring/src/main/java/com/vaadin/flow/spring/VaadinApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
mcollovati
previously approved these changes
Oct 27, 2023
Added `vaadin.i18n.location-pattern` property. Added Conditional annotation with Condition implemented by DefaultI18NProviderFactory. Also moved location pattern to create(String) method.
caalador
previously approved these changes
Oct 27, 2023
mcollovati
reviewed
Oct 27, 2023
vaadin-spring/src/main/java/com/vaadin/flow/spring/VaadinApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
mcollovati
previously approved these changes
Oct 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
mcollovati
approved these changes
Oct 30, 2023
|
This ticket/PR has been released with Vaadin 24.3.0.alpha4 and is also targeting the upcoming stable 24.3.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends DefaultI18NProvider (#5917) for Spring.
VaadinApplicationConfigurationdefinesDefaultI18NProviderbean and initializes it with locales based on translation properties files found in the classpath under '/vaadin-i18n' path.Fixes: #17836