Validation fixes #18535
Merged
Validation fixes #18535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tepi
force-pushed
the
validation-changes
branch
from
693cbbf
to
d73317c
Compare
|
mcollovati
approved these changes
Jan 26, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Changes: - Once Binder.handleFieldValueChange runs for a binding when readBean was used, the whole binder will be silently validated also. BinderValidationStatusHandler is called like before (only contains status from changed binding), but StatusChangeEvent is now fired considering all bindings and if possible bean validators as well. - Once Binder.handleFieldValueChange runs for a binding when setBean was used, doWriteIfValid will validate all bindings, not only the changed ones. This prevents writing an invalid bean in cases where one or more of the initial values are in invalid state (but not marked as such since setBean resets validation status), but they have not been changed from their initial value(s). Calling setAsRequiredEnabled with a changed value no longer triggers validation, since that validation is now handled elsewhere when needed as stated above. Minor Javadoc fixes, trying to align Javadocs with code. Fixes #18163 Fixes #4988 Fixes #17515
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Changes: - Once Binder.handleFieldValueChange runs for a binding when readBean was used, the whole binder will be silently validated also. BinderValidationStatusHandler is called like before (only contains status from changed binding), but StatusChangeEvent is now fired considering all bindings and if possible bean validators as well. - Once Binder.handleFieldValueChange runs for a binding when setBean was used, doWriteIfValid will validate all bindings, not only the changed ones. This prevents writing an invalid bean in cases where one or more of the initial values are in invalid state (but not marked as such since setBean resets validation status), but they have not been changed from their initial value(s). Calling setAsRequiredEnabled with a changed value no longer triggers validation, since that validation is now handled elsewhere when needed as stated above. Minor Javadoc fixes, trying to align Javadocs with code. Fixes #18163 Fixes #4988 Fixes #17515
vaadin-bot
added a commit
that referenced
this pull request
Jan 26, 2024
Changes: - Once Binder.handleFieldValueChange runs for a binding when readBean was used, the whole binder will be silently validated also. BinderValidationStatusHandler is called like before (only contains status from changed binding), but StatusChangeEvent is now fired considering all bindings and if possible bean validators as well. - Once Binder.handleFieldValueChange runs for a binding when setBean was used, doWriteIfValid will validate all bindings, not only the changed ones. This prevents writing an invalid bean in cases where one or more of the initial values are in invalid state (but not marked as such since setBean resets validation status), but they have not been changed from their initial value(s). Calling setAsRequiredEnabled with a changed value no longer triggers validation, since that validation is now handled elsewhere when needed as stated above. Minor Javadoc fixes, trying to align Javadocs with code. Fixes #18163 Fixes #4988 Fixes #17515 Co-authored-by: Teppo Kurki <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Jan 26, 2024
Changes: - Once Binder.handleFieldValueChange runs for a binding when readBean was used, the whole binder will be silently validated also. BinderValidationStatusHandler is called like before (only contains status from changed binding), but StatusChangeEvent is now fired considering all bindings and if possible bean validators as well. - Once Binder.handleFieldValueChange runs for a binding when setBean was used, doWriteIfValid will validate all bindings, not only the changed ones. This prevents writing an invalid bean in cases where one or more of the initial values are in invalid state (but not marked as such since setBean resets validation status), but they have not been changed from their initial value(s). Calling setAsRequiredEnabled with a changed value no longer triggers validation, since that validation is now handled elsewhere when needed as stated above. Minor Javadoc fixes, trying to align Javadocs with code. Fixes #18163 Fixes #4988 Fixes #17515 Co-authored-by: Teppo Kurki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Binder.handleFieldValueChangeruns for a binding whenreadBeanwas used, the whole binder will be silently validated also.BinderValidationStatusHandleris called like before (only contains status from changed binding), butStatusChangeEventis now fired considering all bindings and if possible bean validators as well.Binder.handleFieldValueChangeruns for a binding whensetBeanwas used,doWriteIfValidwill validate all bindings, not only the changed ones. This prevents writing an invalid bean in cases where one or more of the initial values are in invalid state (but not marked as such sincesetBeanresets validation status), but they have not been changed from their initial value(s).setAsRequiredEnabledwith a changed value no longer triggers validation, since that validation is now handled elsewhere when needed as stated above.Fixes #18163
Fixes #4988
Fixes #17515
Probably fixes some other binder / validation issues as well.