fix: fix setBean single binding write and add tests #18891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollovati
reviewed
Mar 6, 2024
flow-data/src/main/java/com/vaadin/flow/data/binder/Binder.java
Outdated
Show resolved
Hide resolved
flow-data/src/test/java/com/vaadin/flow/data/binder/BinderTest.java
Outdated
Show resolved
Hide resolved
|
mcollovati
approved these changes
Mar 6, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
* fix: fix setBean single binding write and add tests * improve javadocs * Address review feedback
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
* fix: fix setBean single binding write and add tests * improve javadocs * Address review feedback
vaadin-bot
added a commit
that referenced
this pull request
Mar 6, 2024
* fix: fix setBean single binding write and add tests * improve javadocs * Address review feedback Co-authored-by: Teppo Kurki <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Mar 6, 2024
* fix: fix setBean single binding write and add tests * improve javadocs * Address review feedback Co-authored-by: Teppo Kurki <[email protected]>
|
This ticket/PR has been released with Vaadin 24.4.0.alpha9 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18869
Adds missing test to confirm that setBean works as before.