fix: do not block navigation to current url #19730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
reviewed
Jul 30, 2024
|
Perhaps we should add the TestView from the issue with a RouterLink targeting self and use a messageList (like we have in DomEventFilterView) and check that messages are added correctly so that it is not broken by mistake later on. |
|
Added test to check correct navigation events happening |
caalador
reviewed
Jul 31, 2024
flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/NavigationEventsIT.java
Outdated
Show resolved
Hide resolved
|
caalador
approved these changes
Jul 31, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
Lets navigation cause server round-trip, when navigation is triggered by clicking a link. Fixes #19635
vaadin-bot
added a commit
that referenced
this pull request
Jul 31, 2024
Lets navigation cause server round-trip, when navigation is triggered by clicking a link. Fixes #19635 Co-authored-by: Teppo Kurki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets navigation cause server round-trip, when navigation is triggered by clicking a link.
Fixes #19635