Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options should correct the reactEnable flag #19852

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

caalador
Copy link
Contributor

The reactEnable flag should be
automatically corrected to
false if vaadin router is used
instead of react router.

The reactEnable flag should be
automatically corrected to
false if vaadin router is used
instead of react router.
Copy link

sonarcloud bot commented Aug 30, 2024

@mshabarov mshabarov enabled auto-merge (squash) August 30, 2024 09:40
Copy link

Test Results

1 135 files  ± 0  1 135 suites  ±0   1h 28m 35s ⏱️ +6s
7 381 tests ± 0  7 331 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 705 runs  +17  7 649 ✅ +20  56 💤  - 3  0 ❌ ±0 

Results for commit fea7c64. ± Comparison against base commit c8ff229.

@mshabarov mshabarov merged commit fea03c8 into main Aug 30, 2024
25 of 26 checks passed
@mshabarov mshabarov deleted the issues/add-layout-validation branch August 30, 2024 09:45
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha13 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants