Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate layout.json #19933

Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: generate layout.json #19933

merged 2 commits into from
Sep 13, 2024

Conversation

caalador
Copy link
Contributor

Genrate a layout.json for
Hilla to automatically
enable server layouts

part of vaadin/hilla#2709

@caalador
feat: generate layout.json
2a23488 
Genrate a layout.json for
Hilla to automatically
enable server layouts

part of vaadin/hilla#2709
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

Test Results

1 135 files  ± 0  1 135 suites  ±0   1h 29m 29s ⏱️ + 5m 22s
7 393 tests + 1  7 343 ✅ + 1  50 💤 ±0  0 ❌ ±0 
7 741 runs  +13  7 681 ✅ +13  60 💤 ±0  0 ❌ ±0 

Results for commit 2ef97f8. ± Comparison against base commit dad51c2.

♻️ This comment has been updated with latest results.

tltv
tltv reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@tltv tltv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • test is failing because DevModeClassFinderTest needs the Layout.class in knownClasses List
  • cleanup should probably delete layout.json file?
  • unit test for the new layout.json file and the expected content

@caalador
Fix test expectation
2ef97f8 
Add file for cleanup
add test for file creation and generated content
@caalador
Copy link
Contributor Author

done.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 12, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@caalador caalador merged commit e4a00ab into main Sep 13, 2024
25 of 26 checks passed
@caalador caalador deleted the issues/2709-opt-out-hilla branch September 13, 2024 04:25
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tltv tltv tltv approved these changes

Assignees
No one assigned
Labels
Released with Vaadin 24.5.0 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caalador @vaadin-bot @tltv