-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refresh items after changing filtering or sorting with DataViews #20263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JavaDoc in ListDataView
could mention for setFilter
, addFilter
, setSortComparator
, addSortComparator
that refreshAll
is run automatically in the end just to be clear.
Added this clarification to filter, sort and also for add items methods. |
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version. |
Description
Refreshes items in Vaadin list components, when the filtering or sorting is changed via DataView API.
This is a behaviour change, but in the same time I believe this is a desired behaviour in most of the cases.
Let's only pick it to next release - 24.6 because of that.
We should remove
dataCommunicator.reset();
via vaadin/flow-components#5304 next.Part-of vaadin/flow-components#5303
Type of change
Checklist
Additional for
Feature
type of change