Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable easier override for SpringServlet #20276

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Oct 17, 2024

Fixes #19994

Copy link

sonarcloud bot commented Oct 17, 2024

Copy link

Test Results

1 142 files  ± 0  1 142 suites  ±0   1h 25m 37s ⏱️ +44s
7 464 tests ± 0  7 414 ✅ + 1  50 💤 ±0  0 ❌ ±0 
7 821 runs   - 12  7 761 ✅  - 11  60 💤 ±0  0 ❌ ±0 

Results for commit 6b9c02b. ± Comparison against base commit 1e3308d.

Copy link
Member

@tltv tltv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tepi tepi merged commit b026b9d into main Oct 22, 2024
26 checks passed
@tepi tepi deleted the feat/easier-override-for-springservlet branch October 22, 2024 10:50
vaadin-bot added a commit that referenced this pull request Oct 22, 2024
vaadin-bot added a commit that referenced this pull request Oct 22, 2024
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow simpler extension of the SpringServlet / structuring of SpringBootAutoConfiguration
3 participants