fix: find file-routes.json in dev bundle #20324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollovati
reviewed
Oct 23, 2024
| /** | ||
| * Path of the folder to custom dev-bundle. | ||
| */ | ||
| public static final String DEV_BUNDLE_FOLDER = "target/dev-bundle/"; |
There was a problem hiding this comment.
I guess this will most likely not work for gradle projects.
There was a problem hiding this comment.
StaticFileServer seems to use DevBundleUtils.findBundleFile(...) to get resources from the application bundle
assetInDevBundleUrl = DevBundleUtils.findBundleFile(
deploymentConfiguration.getProjectFolder(),
deploymentConfiguration.getBuildFolder(), assetInDevBundle);There was a problem hiding this comment.
Good catch, thanks! I'll see if this can be used here as well.
tltv
reviewed
Oct 25, 2024
flow-server/src/main/java/com/vaadin/flow/internal/menu/MenuRegistry.java
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/internal/menu/MenuRegistry.java
Show resolved
Hide resolved
|
tltv
approved these changes
Oct 25, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 27, 2024
vaadin-bot
added a commit
that referenced
this pull request
Oct 28, 2024
Fixes #20290 Co-authored-by: Teppo Kurki <[email protected]>
|
This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20290