Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Theme asset collection and ComponentTracker path check #20390

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Nov 1, 2024

Fix collection of theme assets
in windows. Fix componentTracker
patch check in windows.

Fix collection of theme assets
in windows. Fix componentTracker
patch check in windows.
Copy link

sonarcloud bot commented Nov 1, 2024

Copy link

github-actions bot commented Nov 1, 2024

Test Results

1 142 files  ±0  1 142 suites  ±0   1h 25m 55s ⏱️ + 1m 16s
7 477 tests ±0  7 427 ✅ ±0  50 💤 ±0  0 ❌ ±0 
7 822 runs  +9  7 762 ✅ +7  60 💤 +2  0 ❌ ±0 

Results for commit 62f5e6d. ± Comparison against base commit bae8c0e.

@mshabarov mshabarov requested a review from tltv November 4, 2024 12:40
Copy link
Member

@tltv tltv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with test-themes integration test and assets works again in Windows with this change.

@tltv tltv merged commit 731212e into main Nov 4, 2024
26 checks passed
@tltv tltv deleted the test/window-fixes branch November 4, 2024 15:11
vaadin-bot pushed a commit that referenced this pull request Nov 6, 2024
Fix collection of theme assets
in windows. Fix componentTracker
patch check in windows.
vaadin-bot added a commit that referenced this pull request Nov 6, 2024
…20414)

Fix collection of theme assets
in windows. Fix componentTracker
patch check in windows.

Co-authored-by: caalador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants