-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: opt-out web components from package.json #20392
Conversation
Adds new property `vaadin.include.web.component.npm.packages` (or `includeWebComponentNpmPackages` in Maven configurations). By default, it's `true` and everything works as before. `false` will exclude all web component dependencies from `package.json` for development mode (Vite/dev bundle) and production bundle build. Excluded dependencies are all Vaadin core components (e.g. button, grid, login, etc.) and commercial components (e.g. charts, rich-text-editor, etc.), but not lumo/material themes. RelatedTo: #19948
flow-server/src/main/java/com/vaadin/flow/server/frontend/VersionsJsonConverter.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/frontend/ExclusionFilter.java
Outdated
Show resolved
Hide resolved
Fills exclusions always when includeWebComponents=false. Makes it behave same by all callers. Updated couple tests.
flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdaterTest.java
Outdated
Show resolved
Hide resolved
flow-server/src/test/java/com/vaadin/flow/server/frontend/NodeUpdaterTest.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/InitParameters.java
Outdated
Show resolved
Hide resolved
Don't exclude theme dependencies that are in lit-mode.
Just running a project with
I still get in my
Am I missing something or is the value not propagated correctly? |
Try again. Now it should be written in build-info from maven configs and delegated forward. Update: works for me with latest change. Did you exclude all core component dependencies plus copilot? Exclude copilot like this (this is just temporary and copilot needs to be updated after this PR is ready):
|
flow-plugins/flow-plugin-base/src/main/java/com/vaadin/flow/plugin/base/BuildFrontendUtil.java
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version. |
Adds new property
npm.excludeWebComponents
(ornpmExcludeWebComponents
in Maven configurations). By default, it'sfalse
and everything works as before.true
will exclude all web component dependencies frompackage.json
for development mode (Vite/dev bundle) and production bundle build. Excluded dependencies are all Vaadin core components (e.g. button, grid, login, etc.) and commercial components (e.g. charts, rich-text-editor, etc.), but not lumo/material themes.RelatedTo: #19948