Fix performance issue in Grid initial render with Footer (#10705)

* Fix performance issue in Grid initial render with Footer
vaadin · Mar 13, 2018 · 5deec67 · 5deec67
1 parent 867ea63
commit 5deec67
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java b/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java
@@ -211,10 +211,9 @@ protected void init() {
 
         Grid<JsonObject> grid = getWidget();
 
-        // Remove default headers when initializing Grid widget
-        while (grid.getHeaderRowCount() > 0) {
-            grid.removeHeaderRow(0);
-        }
+        // Trigger early redraw of both grid static sections.
+        grid.setHeaderVisible(!grid.isHeaderVisible());
+        grid.setFooterVisible(!grid.isFooterVisible());
 
         registerRpc(GridClientRpc.class, new GridClientRpc() {
 

diff --git a/uitest/src/main/java/com/vaadin/tests/components/grid/GridManyColumns.java b/uitest/src/main/java/com/vaadin/tests/components/grid/GridManyColumns.java
@@ -22,6 +22,7 @@ protected void setup(VaadinRequest request) {
                     .setWidth(200);
         }
         grid.setItems(IntStream.range(0, 10).boxed().map(i -> ""));
+        grid.appendFooterRow();
         addComponent(grid);
     }
 }