Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only remove caption margin from the first visible tab. #12078

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

Ansku
Copy link
Member

@Ansku Ansku commented Aug 17, 2020

Fixes #10437


This change is Reviewable

@Ansku Ansku changed the title Don't remove margin from tab captions that follow hidden tabs. Only remove caption margin from the first visible tab. Aug 18, 2020
Copy link
Contributor

@edler-san edler-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@OlliTietavainenVaadin OlliTietavainenVaadin merged commit a6a1e1d into vaadin:master Aug 19, 2020
@TatuLund TatuLund added this to the 8.11.3 milestone Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden Tab in Tabsheet lets surrounding tabs stick to each other
4 participants