-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add generic single valued signal (ValueSignal) #2672
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
==========================================
- Coverage 92.33% 92.10% -0.23%
==========================================
Files 76 79 +3
Lines 2492 2521 +29
Branches 646 652 +6
==========================================
+ Hits 2301 2322 +21
- Misses 144 152 +8
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Please mind the TypeScript error in the tests, makes the build red.
Quality Gate failedFailed conditions |
Thanks, for the review. Done. |
This ticket/PR has been released with Hilla 24.5.0.alpha13 and is also targeting the upcoming stable 24.5.0 version. |
Description
Fixes #2623
Type of change
Checklist
Additional for
Feature
type of change