Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generic single valued signal (ValueSignal) #2672

Merged
merged 31 commits into from
Sep 3, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Aug 22, 2024

Description

Fixes #2623

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.10%. Comparing base (5686f0b) to head (08af17a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/ts/react-signals/src/polyfills.ts 0.00% 6 Missing ⚠️
packages/ts/react-signals/src/ValueSignal.ts 90.90% 2 Missing ⚠️
packages/ts/react-signals/src/FullStackSignal.ts 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
- Coverage   92.33%   92.10%   -0.23%     
==========================================
  Files          76       79       +3     
  Lines        2492     2521      +29     
  Branches      646      652       +6     
==========================================
+ Hits         2301     2322      +21     
- Misses        144      152       +8     
  Partials       47       47              
Flag Coverage Δ
unittests 92.10% <78.57%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as ready for review August 28, 2024 16:36
@taefi taefi requested a review from platosha August 30, 2024 09:40
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Please mind the TypeScript error in the tests, makes the build red.

Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@taefi
Copy link
Contributor Author

taefi commented Sep 3, 2024

LGTM overall. Please mind the TypeScript error in the tests, makes the build red.

Thanks, for the review. Done.

@taefi taefi requested a review from platosha September 3, 2024 10:51
@platosha platosha merged commit 18357e7 into main Sep 3, 2024
12 of 15 checks passed
@platosha platosha deleted the feat/signals/value-signal-impl branch September 3, 2024 13:08
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.5.0.alpha13 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Full-stack Signals] add support for having single valued signals other than numbers
4 participants