Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-i18n): support chunked translations loading #2683

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

platosha
Copy link
Contributor

No description provided.

@platosha platosha added the hilla Issues related to Hilla label Aug 30, 2024
@platosha platosha requested a review from taefi August 30, 2024 07:22
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (b2255c8) to head (39bfbd1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2683   +/-   ##
=======================================
  Coverage   92.28%   92.29%           
=======================================
  Files          76       76           
  Lines        2477     2479    +2     
  Branches      643      643           
=======================================
+ Hits         2286     2288    +2     
  Misses        144      144           
  Partials       47       47           
Flag Coverage Δ
unittests 92.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

taefi
taefi previously approved these changes Aug 30, 2024
Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Aug 30, 2024

@platosha platosha merged commit ea802c1 into main Aug 30, 2024
15 checks passed
@platosha platosha deleted the feat/ap/i18n-chunk-loading branch August 30, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants