Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make endpoint data available to copilot #2689

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Sep 1, 2024

No description provided.

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (4ca29e4) to head (f781091).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2689   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files          76       76           
  Lines        2492     2492           
  Branches      646      646           
=======================================
  Hits         2301     2301           
  Misses        144      144           
  Partials       47       47           
Flag Coverage Δ
unittests 92.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a couple tests.

@Artur-
Copy link
Member Author

Artur- commented Sep 2, 2024

What should be tested?

@cromoteca
Copy link
Contributor

No need to test getters IMO. If the underlying code needs tests, that's another problem.

Copy link

sonarcloud bot commented Sep 2, 2024

@platosha platosha merged commit a9fcef4 into main Sep 2, 2024
15 checks passed
@platosha platosha deleted the endpoint-data-available branch September 2, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants